Merged
Conversation
…e docker volumes to include latest splunklib
Description added for how to use add_field method to preserve conditionally added new fields and values.
default value for owner set to "nobody"
chore: remove unused imports
Merge develop with master | Release 1.6.17
Add Support for authorization tokens read from .splunkrc
Modified Streaming and Generating Custom Search Command
commenting the need to set kvstore owner to default value of "nobody" as new property is created for the kvstore owner with default to "nobody"
Default kvstore owner to nobody
Fix mod inputs examples
…chcommands_app-example # Conflicts: # examples/searchcommands_app/setup.py
Fix searchcommands_app example
Add search mode example
fantavlik
reviewed
Nov 11, 2021
CHANGELOG.md
Outdated
| ### Minor changes | ||
| * [#408](https://github.com/splunk/splunk-sdk-python/pull/408) Add search mode example | ||
| * [#409](https://github.com/splunk/splunk-sdk-python/pull/409) Add Support for authorization tokens read from .splunkrc | ||
| * [#413](https://github.com/splunk/splunk-sdk-python/pull/413) Default kvstore owner to nobody |
Contributor
There was a problem hiding this comment.
Can we reference the issue as well so they are linked? #231
fantavlik
approved these changes
Nov 11, 2021
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Suggested some changes to the CHANGELOG but feel free to release once those are made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes
https://github.com/splunk/splunk-sdk-python/blob/develop/README.md#customization [ issue#401 ]
Minor changes